From 3a2bb714a43c2930f000dd116868449b4e12a656 Mon Sep 17 00:00:00 2001 From: Dirk Engling Date: Sun, 25 Oct 2026 03:28:57 +0100 Subject: Remove unused length calc code from urlencoder --- scan_urlencoded_query.c | 14 +++++--------- scan_urlencoded_query.h | 4 +--- 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/scan_urlencoded_query.c b/scan_urlencoded_query.c index cf0c5b1..4825a4a 100644 --- a/scan_urlencoded_query.c +++ b/scan_urlencoded_query.c @@ -170,16 +170,12 @@ size_t fmt_urlencoded(char *dest, const uint8_t *src, size_t len) { /* strchr would find the terminator, so a zero byte never counts as safe */ if ((c >= 'A' && c <= 'Z') || (c >= 'a' && c <= 'z') || (c >= '0' && c <= '9') || (c && strchr(safe, c))) { - if (dest) - dest[written] = (char)c; - ++written; + dest[written++] = (char)c; } else { - if (dest) { - dest[written] = '%'; - dest[written + 1] = hexdigit[c >> 4]; - dest[written + 2] = hexdigit[c & 15]; - } - written += 3; + dest[written] = '%'; + dest[written + 1] = hexdigit[c >> 4]; + dest[written + 2] = hexdigit[c & 15]; + written += 3; } } diff --git a/scan_urlencoded_query.h b/scan_urlencoded_query.h index 6f12c03..d0929cf 100644 --- a/scan_urlencoded_query.h +++ b/scan_urlencoded_query.h @@ -55,9 +55,7 @@ void scan_urlencoded_skipvalue(char **string); ssize_t scan_fixed_int(char *data, size_t len, int *number); /* The other direction: percent encode len bytes from src into dest and return - how many characters were written, or how many would be needed when dest is - NULL. dest needs room for three times len. - */ + how many characters were written. dest needs room for three times len. */ size_t fmt_urlencoded(char *dest, const uint8_t *src, size_t len); #endif -- cgit v1.3