cccms/app/controllers/menu_items_controller.rb, branch master[no description]https://erdgeist.org/gitweb/cccms/atom?h=master2026-06-25T23:59:57ZStage 4: Rails 5.2 -> 6.1 on Ruby 2.7.22026-06-25T23:59:57Zerdgeisterdgeist@erdgeist.org2026-06-25T23:59:57Zurn:sha1:c06723ee715512c2033c7786c48f15674585b56b
- routing-filter 0.6.3 -> 0.7.0 (Rails 6.1 compatibility)
- RSS named routes rss_xml/rss_rdf added
- RouteWithParams workarounds: will_paginate_patch, content_path shim, safe_path helper
- Paperclip removed, replaced with FileAttachment concern (preserves URL scheme)
- Assets resource moved to /admin/assets (Sprockets middleware conflict)
- ApplicationRecord base class added, all models migrated
- Strong parameters added to Assets, Occurrences, Events, MenuItems controllers
- update_attributes -> update throughout
- render :nothing -> head :ok/:not_found throughout
- language_selector rewritten (removes :overwrite_params)
- Environment files updated for Rails 6.1 (eager_load, public_file_server, ActionMailer)
- Arel::Visitors::DepthFirst and Integer/Float duration patches removed from test_helper
- AssetsController tests added (10 tests covering upload, variants, destroy, auth)
- ImageMagick geometry: 460x250! for headline crop (not # which is invalid in IM6)
129 runs, 311 assertions, 5 failures (all pre-existing), 0 errors
Rails 5.2 application fixes2026-06-25T15:50:55Zerdgeisterdgeist@erdgeist.org2026-06-25T15:50:55Zurn:sha1:26030c71c7b300c30367222f263d74b8d2142ecf
- Rename before_filter → before_action across all controllers
- Fix string conditions in validators to lambda syntax (node.rb)
- Fix publish_draft!: move staged slug/parent logic outside draft guard,
use move_to_child_of for parent changes, add nil guard for no-op calls
- Fix update_unique_names_of_children: use parent_id traversal instead
of lft/rgt descendants (awesome_nested_set 3.x lft/rgt update bug)
- Fix unique_path to return Array instead of String
- Fix Occurrence.delete_all syntax for Rails 5
- Fix Page.find_with_outdated_translations: use includes instead of all
- Fix outdated_translations?: use find instead of splat array
Stage 1 complete: Rails 2.3.5 to Rails 3.2.22.5 upgrade2026-06-24T02:13:16Zerdgeisterdgeist@erdgeist.org2026-06-24T02:13:16Zurn:sha1:e0a7e0fec760ba12c8067a37e10c96f1f05876e2
- Converted plugins to gems (Gemfile)
- Updated config structure (application.rb, boot.rb, environment.rb)
- Converted routes to Rails 3 DSL
- Converted named_scope to scope throughout models
- Converted find(:all, :conditions) to where() chains
- Fixed has_many :order to use ordering scope
- Updated session store and secret token configuration
- Fixed exception_notification middleware configuration
- Patched Ruby 2.4 / Rails 3.2 incompatibilities:
- Integer/Float duration arithmetic (ActiveSupport)
- Arel visit_Integer for PostgreSQL adapter
- create_database String/Integer coercion
- ActionController consider_all_requests_local
- Migrated taggings schema for acts-as-taggable-on
- Replaced dynamic_form gem with custom form_error_messages helper
- Fixed Rails 3 block helper syntax (form_for, form_tag, fields_for)
- Fixed admin layout yield
- Updated test suite for Rails 3 APIs
Marked Controllers private / public and added authorization filters accordingly2009-09-06T15:23:32Zhuklcontact@smyck.org2009-09-06T15:23:32Zurn:sha1:4c82210b4ab1d60962b170fdabe8a44515969e94added sorting (via drag and drop) and deleting of menu items. Its not perfect though and needs more styling. I'm unsure about the proper route for the sort action. Will investigate.2009-08-09T12:45:12Zhuklcontact@smyck.org2009-08-09T12:45:12Zurn:sha1:97aecb984afa6a7d8d1424f544b8e32d8c87603dediting menu items now works to. also some minor changes2009-08-09T10:42:53Zhuklcontact@smyck.org2009-08-09T10:42:53Zurn:sha1:9e3f29257ffae63bffe4fb2023c7090cfe4a73ferefactored the way new menu items are created. went back to rest and added the js ajax search to fill out the form for you. much cleaner, unobtrusive approach.2009-08-09T09:57:44Zhuklcontact@smyck.org2009-08-09T09:57:44Zurn:sha1:9b4d055b649ad24ad1482f72d138aa73da1e4bd7lots of new code to manage menu items - harder than expected :/2009-08-08T20:38:48Zhuklcontact@smyck.org2009-08-08T20:38:48Zurn:sha1:46117a9f103e2d547be2a47724e872b3f57ce983added menu items resource2009-08-08T13:38:20Zhuklcontact@smyck.org2009-08-08T13:38:20Zurn:sha1:8345fb8001e82b145b9ce4c8558d4d4712ebad60