3 files changed, 53 insertions, 16 deletions

diff --git a/test/controllers/menu_items_controller_test.rb b/test/controllers/menu_items_controller_test.rb
index 15a7b30b..d09198a3 100644
--- a/test/controllers/menu_items_controller_test.rb
+++ b/test/controllers/menu_items_controller_test.rb
@@ -9,7 +9,7 @@ class MenuItemsControllerTest < ActionController::TestCase
   end
 
   test "updating stores a title per locale" do
-    login_as :quentin
+    login_as :aaron
     item = create_menu_item
 
     patch :update, params: { :id => item.id,
@@ -20,7 +20,7 @@ class MenuItemsControllerTest < ActionController::TestCase
   end
 
   test "blanking a non-default title falls back to the default locale" do
-    login_as :quentin
+    login_as :aaron
     item = create_menu_item
     patch :update, params: { :id => item.id,
       :menu_item => { :titles => { "de" => "Transparenz", "en" => "Transparency" } } }
@@ -33,7 +33,7 @@ class MenuItemsControllerTest < ActionController::TestCase
   end
 
   test "a blank default title is rejected" do
-    login_as :quentin
+    login_as :aaron
     item = create_menu_item
     patch :update, params: { :id => item.id,
       :menu_item => { :titles => { "de" => "" } } }
@@ -41,4 +41,11 @@ class MenuItemsControllerTest < ActionController::TestCase
     assert_response :success        # re-rendered :edit, not a redirect
     assert_not_equal "", item.reload.translations.find_by(:locale => "de").title
   end
+
+  test "an editor without redaktion cannot reach the menu" do
+    login_as :quentin
+    get :index
+    assert_redirected_to admin_path
+    assert_equal I18n.t("flash.common.redaktion_required"), flash[:error]
+  end
 end
diff --git a/test/controllers/users_controller_test.rb b/test/controllers/users_controller_test.rb
index 14133029..fe099928 100644
--- a/test/controllers/users_controller_test.rb
+++ b/test/controllers/users_controller_test.rb
@@ -2,11 +2,11 @@ require 'test_helper'
 
 class UsersControllerTest < ActionController::TestCase
 
-  test "get index as regular user renders stripped partial" do
+  test "an editor without admin cannot reach the user list" do
     login_as :quentin
     get :index
-    assert_response :success
-    assert_select "a", { :count => 0, :text => "Destroy" }
+    assert_redirected_to admin_path
+    assert_equal I18n.t("flash.common.admin_required"), flash[:error]
   end
 
   test "get index as admin shows every group with per-row actions" do
@@ -27,10 +27,10 @@ class UsersControllerTest < ActionController::TestCase
     login_as :quentin
     get :new
     assert_response :redirect
-    assert_redirected_to users_path
+    assert_redirected_to admin_path
     assert_equal(
       I18n.t("flash.common.admin_required"),
-      flash[:notice]
+      flash[:error]
     )
   end
   
@@ -82,20 +82,20 @@ class UsersControllerTest < ActionController::TestCase
       }
     end
     
-    assert_redirected_to users_path
+    assert_redirected_to admin_path
     assert_equal(
       I18n.t("flash.common.admin_required"),
-      flash[:notice]
+      flash[:error]
     )
   end
   
   test "get edit of another user being logged in as regular user wont work" do
     login_as :quentin
     get :edit, params: { :id => User.find_by_login("aaron").id }
-    assert_redirected_to users_path
+    assert_redirected_to admin_path
     assert_equal(
       I18n.t("flash.common.admin_required"),
-      flash[:notice]
+      flash[:error]
     )
   end
   
@@ -115,10 +115,10 @@ class UsersControllerTest < ActionController::TestCase
     user = User.find_by_login("aaron")
     login_as :quentin
     put :update, params: { :id => user.id, :user => {:login => "random"} }
-    assert_redirected_to users_path
+    assert_redirected_to admin_path
     assert_equal(
       I18n.t("flash.common.admin_required"),
-      flash[:notice]
+      flash[:error]
     )
   end
   
@@ -140,7 +140,7 @@ class UsersControllerTest < ActionController::TestCase
 
   test "showing a user" do
     login_as :quentin
-    get :show, params: { :id => User.find_by_login("aaron").id }
+    get :show, params: { :id => users(:quentin).id }
     assert_response :success
   end
   
@@ -148,7 +148,7 @@ class UsersControllerTest < ActionController::TestCase
     login_as :quentin
     put :deactivate, params: { :id => users(:quentin).id }
 
-    assert_redirected_to users_path
+    assert_redirected_to admin_path
     assert_not users(:quentin).reload.alumni?
   end
   
@@ -227,4 +227,16 @@ class UsersControllerTest < ActionController::TestCase
     assert_response :success
     assert_select "h2", :text => /#{I18n.t("users.index.group_alumni")}/
   end
+
+  test "an editor without admin cannot create accounts" do
+    login_as :quentin
+    get :new
+    assert_redirected_to admin_path
+  end
+
+  test "an editor cannot read another account by id" do
+    login_as :quentin
+    get :show, params: { :id => users(:aaron).id }
+    assert_redirected_to admin_path
+  end
 end
diff --git a/test/fixtures/users.yml b/test/fixtures/users.yml
index f8d32d3c..2c433067 100644
--- a/test/fixtures/users.yml
+++ b/test/fixtures/users.yml
@@ -14,3 +14,21 @@ aaron:
   crypted_password:          740a48caf7dd5ff11318d812d57c0a0928cfbc12 # 'monkey'
   created_at:                2024-01-02 00:00:00
   roles:                     ["admin", "redaktion"]
+
+redella:
+  id:                        3
+  login:                     redella
+  email:                     redella@example.com
+  salt:                      cf993996a70d31f924aff17a5f997722cb6ec2dd
+  crypted_password:          11c672158b0eb6e8c91c438b3eb844902308b138 # 'monkey'
+  created_at:                2024-01-03 00:00:00
+  roles:                     ["redaktion"]
+
+alufa:
+  id:                        4
+  login:                     alufa
+  email:                     alufa@example.com
+  salt:                      cf993996a70d31f924aff17a5f997722cb6ec2dd
+  crypted_password:          11c672158b0eb6e8c91c438b3eb844902308b138 # 'monkey'
+  created_at:                2024-01-04 00:00:00
+  roles:                     ["redaktion", "alumni"]