From c14683fe37fabe06082f43e8bf67debc4cca7297 Mon Sep 17 00:00:00 2001 From: erdgeist Date: Tue, 21 Jul 2026 14:24:59 +0200 Subject: Render asset credit inside the gallery lightbox correctly GLightbox's own selector-based description feature never actually resolved a selector in three different attempts -- literal text, then a resolved-but-empty div, then apparently not firing at all against the installed (unversioned) build. Replaced with a small afterSlideLoad handler that reads a plain data-credit-selector attribute and copies the real element's HTML into the slide's description area directly, depending only on GLightbox handing back a real DOM node per slide -- a much smaller contract than trusting its own caption-resolution feature. Renamed the credit div's class from glightbox-desc, since that name is reserved by the library's own bundled CSS (display: none !important) and can't be reliably overridden from here. Also: distinguishes the credit line and the "N Bilder" caption from ordinary body text (italic, muted, matching .author_and_date's existing convention), and makes the lightbox's caption card follow the site's light/dark toggle via Canvas/CanvasText, since the library's bundled theme never adapts to it on its own. --- app/helpers/content_helper.rb | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'app/helpers') diff --git a/app/helpers/content_helper.rb b/app/helpers/content_helper.rb index 5b672598..b3c6bad1 100644 --- a/app/helpers/content_helper.rb +++ b/app/helpers/content_helper.rb @@ -153,7 +153,7 @@ module ContentHelper def asset_credit(asset) return nil unless asset - return nil if asset.creator.blank? && asset.source_url.blank? && asset.license_key.blank? + return nil unless asset.has_credit? license = AssetLicense.find(asset.license_key) @@ -173,4 +173,8 @@ module ContentHelper full = license_text ? safe_join([attribution, license_text], ", ") : attribution safe_join([full, "."]) end + + def glightbox_data(image, title) + "title: #{title.to_s.tr(';', ',')};" + end end -- cgit v1.3