From c14683fe37fabe06082f43e8bf67debc4cca7297 Mon Sep 17 00:00:00 2001 From: erdgeist Date: Tue, 21 Jul 2026 14:24:59 +0200 Subject: Render asset credit inside the gallery lightbox correctly GLightbox's own selector-based description feature never actually resolved a selector in three different attempts -- literal text, then a resolved-but-empty div, then apparently not firing at all against the installed (unversioned) build. Replaced with a small afterSlideLoad handler that reads a plain data-credit-selector attribute and copies the real element's HTML into the slide's description area directly, depending only on GLightbox handing back a real DOM node per slide -- a much smaller contract than trusting its own caption-resolution feature. Renamed the credit div's class from glightbox-desc, since that name is reserved by the library's own bundled CSS (display: none !important) and can't be reliably overridden from here. Also: distinguishes the credit line and the "N Bilder" caption from ordinary body text (italic, muted, matching .author_and_date's existing convention), and makes the lightbox's caption card follow the site's light/dark toggle via Canvas/CanvasText, since the library's bundled theme never adapts to it on its own. --- app/views/content/_asset_credits.html.erb | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'app/views/content/_asset_credits.html.erb') diff --git a/app/views/content/_asset_credits.html.erb b/app/views/content/_asset_credits.html.erb index 85739d09..5959abd1 100644 --- a/app/views/content/_asset_credits.html.erb +++ b/app/views/content/_asset_credits.html.erb @@ -1,11 +1,9 @@ <% if @page.assets.images.any? %>
<% @page.assets.images.each do |image| %> - <% credit = asset_credit(image) %> - <% next unless credit %>
"> - <%= credit %> + class="asset_credit_block<%= " headline_credit" if image == @headline_asset %>"> + <%= asset_credit(image) %>
<% end %>
-- cgit v1.3