From 36b5324900968afc7498950c14ad13be5c061a7c Mon Sep 17 00:00:00 2001
From: erdgeist <erdgeist@erdgeist.org>
Date: Mon, 6 Jul 2026 16:49:45 +0200
Subject: Restructure nodes#show and nodes#new around
 node_description/node_content

nodes#show's flat <table> of label/value pairs grew unreadable once
Admin Preview and Public Preview were added alongside Public Link -
switched to the div.node_description/div.node_content pattern already
used by nodes#edit, grouped into People/Dates/Links/Revisions/Tags/
Events/Children sections rather than one undifferentiated list.

People/Dates/Links use a flex-based item layout, not a second <table> -
multiple independent tables sharing one outer width but different
column counts produced misaligned columns with no shared grid. Flex
items size to their own content with a shared minimum instead.

Revisions and Children are both collapsed via <details>, no JS needed -
previously nodes#show didn't list a node's children at all, blocking
the ability to find/navigate erfa and chaostreff pages without already
knowing they're now standalone nodes. Revision list items link to
node_revision_path(@node, page) - the actual per-revision diff/restore
view, not the plain index.

nodes#new converted to the same pattern for visual consistency, plus a
few things surfaced along the way: submit buttons were unstyled
site-wide (a bare input[type=submit] with no border, fill, or hover
state - Create on this exact page was easy to miss entirely), fixed
with a bordered/bold treatment reusing the existing form.button_to
visual language rather than introducing a fourth button style. Title
regained the bold weight it had before the table rewrite dropped it
silently. Tag list grouping and full link/button semantic taxonomy
(show vs edit/add vs publish/revoke vs destroy, applied consistently
across every link on the page, not just buttons) are known follow-ups,
not attempted here.
---
 app/views/nodes/new.html.erb | 57 ++++++++++++++++++++------------------------
 1 file changed, 26 insertions(+), 31 deletions(-)

(limited to 'app/views/nodes/new.html.erb')

diff --git a/app/views/nodes/new.html.erb b/app/views/nodes/new.html.erb
index f5574547..0a053250 100644
--- a/app/views/nodes/new.html.erb
+++ b/app/views/nodes/new.html.erb
@@ -6,13 +6,11 @@
   </div>
 <% end %>
 
-<p>What kind of node do you want to create?</p>
-
 <%= form_tag nodes_path do %>
-<table id="new_node">
-  <tr>
-    <td class="description">Type</td>
-    <td>
+<div id="new_node">
+
+  <div class="node_description">Type</div>
+  <div class="node_content">
     <% CccConventions::NODE_KINDS.each do |kind, config| %>
       <p>
         <%= radio_button_tag :kind, kind, kind == "generic",
@@ -23,35 +21,32 @@
         <% end %>
       </p>
     <% end %>
-    </td>
-  </tr>
-  <tr>
-    <td class="description">Title</td>
-    <td><%= text_field_tag :title %>
+  </div>
+
+  <div class="node_description">Title</div>
+  <div class="node_content">
+    <%= text_field_tag :title %>
     <span class="field_hint">A URL slug will be generated from this automatically. You can review or adjust it afterward under the "metadata" section's Slug field.</span>
-    </td>
-  </tr>
-  <tr id="parent_search_field">
-    <td class="description">Parent</td>
-    <td>
+  </div>
+
+  <div id="parent_search_field">
+    <div class="node_description">Parent</div>
+    <div class="node_content">
       <%= text_field_tag :parent_search_term, @parent_name %>
       <%= hidden_field_tag :parent_id, @parent_id %>
-      <div id="search_results">
-
-      </div>
-    </td>
-  </tr>
-  <tr>
-  <td class="description">Resulting path</td>
-  <td>
+      <div id="search_results"></div>
+    </div>
+  </div>
+
+  <div class="node_description">Resulting path</div>
+  <div class="node_content">
     <span id="resulting_path">—</span>
     <button type="button" id="copy_resulting_path" class="unselected">copy</button>
     <span class="field_hint">This preview updates as you type. The final path can still be changed afterward by editing the title (for the last segment) or moving the node to a different parent (for everything before it).</span>
-  </td>
-  </tr>
-  <tr>
-    <td></td>
-    <td class="right"><%= submit_tag "Create" %></td>
-  </tr>
-</table>
+  </div>
+
+  <div class="node_description"></div>
+  <div class="node_content right"><%= submit_tag "Create" %></div>
+
+</div>
 <% end %>
-- 
cgit v1.3