From 9d32458491d79f8e06a706375030c78282f4427b Mon Sep 17 00:00:00 2001 From: erdgeist Date: Sun, 9 Aug 2026 15:45:56 +0200 Subject: Report every editorial attribute in the revision diff diff_against gained external_url, published_at and user. The view renders each metadata section only when that attribute changed, and says so once when none did. Metadata now precedes the locale pointer, which speaks only of translations: above the metadata it read as "nothing changed" on a revision that had moved the page. --- test/controllers/revisions_controller_test.rb | 22 +++++++++++++++++++--- 1 file changed, 19 insertions(+), 3 deletions(-) (limited to 'test/controllers') diff --git a/test/controllers/revisions_controller_test.rb b/test/controllers/revisions_controller_test.rb index 34f00a4f..d9f49e58 100644 --- a/test/controllers/revisions_controller_test.rb +++ b/test/controllers/revisions_controller_test.rb @@ -151,19 +151,35 @@ class RevisionsControllerTest < ActionController::TestCase assert_select "input[type='hidden'][name='end_revision'][value='draft']" end - test "diffing two revisions also shows tag, template, and asset changes" do + test "diffing shows tag, template, external URL and asset changes" do login_as :quentin find_or_create_draft(@node, @user) - @node.draft.tag_list = "update" - @node.draft.save! + draft = @node.draft + draft.tag_list = "update" + draft.template_name = "title_only" + draft.external_url = "https://example.org/" + draft.save! + draft.related_assets.create!(:asset => Asset.create!(:name => "diffed", + :upload_file_name => "diffed.png", + :upload_content_type => "image/png")) post(:diff, params: { :node_id => @node.id, :start_revision => @node.pages.first.revision, :end_revision => @node.pages.last.revision }) assert_response :success assert_select "h3", Page.human_attribute_name(:tag_list) assert_select "h3", Page.human_attribute_name(:template_name) + assert_select "h3", Page.human_attribute_name(:external_url) assert_select "h3", Page.human_attribute_name(:assets) end + test "a diff with no metadata changes says so once" do + login_as :quentin + + post(:diff, params: { :node_id => @node.id, :start_revision => @node.pages.first.revision, :end_revision => @node.pages.last.revision }) + assert_response :success + assert_select ".diff_meta .diff_unchanged" + assert_select ".diff_meta h3", false + end + test "revisions#index links back to the node" do login_as :quentin get :index, params: { :node_id => @node.id } -- cgit v1.3