Fix s24s stats to ensure no unallocated vector is dereferenced. Drive-by fix for the ip= scanner in the http parser

1 files changed, 3 insertions, 1 deletions

diff --git a/src/ot_http.c b/src/ot_http.c
index 1b5281c..262936e 100644
--- a/src/ot_http.c
+++ b/src/ot_http.c
@@ -692,8 +692,10 @@ static ssize_t     http_handle_announce(const int64_t sock, struct ot_workstruct
     {
       char *tmp_buf1 = ws->reply, *tmp_buf2 = ws->reply + 16;
       len           = urlencoded_parse(&read_ptr, tmp_buf2, ws->outbuf + G_OUTBUF_SIZE, SCAN_SEARCHPATH_VALUE);
+      if (len <= 0)
+        HTTPERROR_400_PARAM;
       tmp_buf2[len] = 0;
-      if ((len <= 0) || ip_parse(tmp_buf2, tmp_buf1) != (size_t)len)
+      if (ip_parse(tmp_buf2, tmp_buf1) != (size_t)len)
         HTTPERROR_400_PARAM;
       OT_SETIP(&ws->peer, tmp_buf1);
     } break;