1 files changed, 28 insertions, 22 deletions

diff --git a/ot_stats.c b/ot_stats.c
index fa456c3..b2eaec9 100644
--- a/ot_stats.c
+++ b/ot_stats.c
@@ -320,7 +320,7 @@ typedef struct {
 /* Fetches stats from tracker */
 size_t stats_top_txt(char *reply, int amount) {
   size_t    j;
-  ot_record top100s[100], top100c[100];
+  ot_record top100s[100], top100c[100], top100l[100];
   char     *r = reply, hex_out[42];
   int       idx, bucket;
 
@@ -329,14 +329,16 @@ size_t stats_top_txt(char *reply, int amount) {
 
   byte_zero(top100s, sizeof(top100s));
   byte_zero(top100c, sizeof(top100c));
+  byte_zero(top100l, sizeof(top100l));
 
   for (bucket = 0; bucket < OT_BUCKET_COUNT; ++bucket) {
-    ot_vector *torrents_list = mutex_bucket_lock(bucket);
+    ot_vector *torrents_list  = mutex_bucket_lock(bucket);
     for (j = 0; j < torrents_list->size; ++j) {
-      ot_torrent *torrent    = (ot_torrent *)(torrents_list->data) + j;
-      size_t      peer_count = torrent->peer_list6->peer_count + torrent->peer_list4->peer_count;
-      size_t      seed_count = torrent->peer_list6->seed_count + torrent->peer_list4->seed_count;
-      idx                    = amount - 1;
+      ot_torrent *torrent     = (ot_torrent *)(torrents_list->data) + j;
+      size_t      peer_count  = torrent->peer_list6->peer_count + torrent->peer_list4->peer_count;
+      size_t      seed_count  = torrent->peer_list6->seed_count + torrent->peer_list4->seed_count;
+      size_t      leech_count = peer_count - seed_count;
+      idx                     = amount - 1;
       while ((idx >= 0) && (peer_count > top100c[idx].val))
         --idx;
       if (idx++ != amount - 1) {
@@ -352,6 +354,14 @@ size_t stats_top_txt(char *reply, int amount) {
         memcpy(&top100s[idx].hash, &torrent->hash, sizeof(ot_hash));
         top100s[idx].val = seed_count;
       }
+      idx = amount - 1;
+      while ((idx >= 0) && (leech_count > top100l[idx].val))
+        --idx;
+      if (idx++ != amount - 1) {
+        memmove(top100l + idx + 1, top100l + idx, (amount - 1 - idx) * sizeof(ot_record));
+        memcpy(&top100l[idx].hash, &torrent->hash, sizeof(ot_hash));
+        top100l[idx].val = leech_count;
+      }
     }
     mutex_bucket_unlock(bucket, 0);
     if (!g_opentracker_running)
@@ -366,6 +376,10 @@ size_t stats_top_txt(char *reply, int amount) {
   for (idx = 0; idx < amount; ++idx)
     if (top100s[idx].val)
       r += sprintf(r, "\t%zd\t%s\n", top100s[idx].val, to_hex(hex_out, top100s[idx].hash));
+  r += sprintf(r, "Top %d torrents by leechers:\n", amount);
+  for (idx = 0; idx < amount; ++idx)
+    if (top100l[idx].val)
+      r += sprintf(r, "\t%zd\t%s\n", top100l[idx].val, to_hex(hex_out, top100l[idx].hash));
 
   return r - reply;
 }
@@ -476,9 +490,9 @@ static void stats_return_fulllog(int *iovec_entries, struct iovec **iovector, ch
         return;
       re = r + 32 * OT_STATS_TMPSIZE;
     }
-    r    += sprintf(r, "%08ld: ", loglist->time);
-    r    += fmt_ip6c(r, loglist->ip);
-    *r++  = '\n';
+    r      += sprintf(r, "%08ld: ", loglist->time);
+    r      += fmt_ip6c(r, loglist->ip);
+    *r++    = '\n';
     memcpy(r, loglist->data, loglist->size);
     r      += loglist->size;
     *r++    = '\n';
@@ -518,10 +532,8 @@ static size_t stats_return_everything(char *reply) {
   r += sprintf(r, "  <completed>\n    <count>%llu</count>\n  </completed>\n", ot_overall_completed);
   r += sprintf(r, "  <connections>\n");
   r += sprintf(r, "    <tcp>\n      <accept>%llu</accept>\n      <announce>%llu</announce>\n      <scrape>%llu</scrape>\n    </tcp>\n",
-               ot_overall_tcp_connections, ot_overall_tcp_successfulannounces, ot_overall_tcp_successfulscrapes);
-  r += sprintf(
-      r,
-      "    <udp>\n      <overall>%llu</overall>\n      <connect>%llu</connect>\n      <announce>%llu</announce>\n      <scrape>%llu</scrape>\n      <missmatch>%llu</missmatch>\n    </udp>\n",
+      ot_overall_tcp_connections, ot_overall_tcp_successfulannounces, ot_overall_tcp_successfulscrapes);
+  r += sprintf(r, "    <udp>\n      <overall>%llu</overall>\n      <connect>%llu</connect>\n      <announce>%llu</announce>\n      <scrape>%llu</scrape>\n      <missmatch>%llu</missmatch>\n    </udp>\n",
       ot_overall_udp_connections, ot_overall_udp_connects, ot_overall_udp_successfulannounces, ot_overall_udp_successfulscrapes,
       ot_overall_udp_connectionidmissmatches);
   r += sprintf(r, "    <livesync>\n      <count>%llu</count>\n    </livesync>\n", ot_overall_sync_count);
@@ -541,14 +553,10 @@ static size_t stats_return_everything(char *reply) {
   return r - reply;
 }
 
-extern const char *g_version_opentracker_c, *g_version_accesslist_c, *g_version_clean_c, *g_version_fullscrape_c, *g_version_http_c, *g_version_iovec_c,
-    *g_version_mutex_c, *g_version_stats_c, *g_version_udp_c, *g_version_vector_c, *g_version_scan_urlencoded_query_c, *g_version_trackerlogic_c,
-    *g_version_livesync_c, *g_version_rijndael_c;
-
 size_t stats_return_tracker_version(char *reply) {
-  return sprintf(reply, "%s%s%s%s%s%s%s%s%s%s%s%s%s%s", g_version_opentracker_c, g_version_accesslist_c, g_version_clean_c, g_version_fullscrape_c,
-                 g_version_http_c, g_version_iovec_c, g_version_mutex_c, g_version_stats_c, g_version_udp_c, g_version_vector_c,
-                 g_version_scan_urlencoded_query_c, g_version_trackerlogic_c, g_version_livesync_c, g_version_rijndael_c);
+#define QUOTE(name) #name
+#define SQUOTE(name) QUOTE(name)
+  return sprintf(reply, "https://erdgeist.org/gitweb/opentracker/commit/?id=" SQUOTE(GIT_VERSION) "\n");
 }
 
 size_t return_stats_for_tracker(char *reply, int mode, int format) {
@@ -775,5 +783,3 @@ void stats_init() {
 void stats_deinit() {
     pthread_cancel(thread_id);
 }
-
-const char *g_version_stats_c = "$Source$: $Revision$\n";