Retire the unused per-node permission subsystem

Every path through Permission raised or lied: validates_presence_of on a
boolean made granted = false unsaveable, since false.blank? is true;
get_permission_for read a nonexistent identifier attribute; has_permission?
called an undefined plural method and returned a truthy relation in every
case; and set_permission mutated granted without saving. Nothing outside the
model referenced it and the table was empty.

1 files changed, 0 insertions, 55 deletions

diff --git a/app/models/user.rb b/app/models/user.rb
index 4d712f6c..e1eff059 100644
--- a/app/models/user.rb
+++ b/app/models/user.rb
@@ -9,9 +9,6 @@ class User < ApplicationRecord
   include Authentication
   include Authentication::ByPassword
 
-  # Associations
-  has_many :permissions
-
   # Validations
   validates_presence_of     :login
   validates_length_of       :login, :within => 1..40
@@ -62,46 +59,6 @@ class User < ApplicationRecord
     write_attribute :email, (value ? value.downcase : nil)
   end
   
-  # Permission stuff
-  
-  def grant(node)
-    set_permission(true, node)
-  end
-  
-  def revoke(node)
-    set_permission(false, node)
-  end
-
-  def inherit(node)    
-    permission = self.permissions.for_node(node).first
-    permission.destroy if permission
-  end
-  
-  def get_permission_for(node)
-    permissions = {}
-    self.permissions.for_node(node).each do |permission|
-      permissions[permission.identifier.to_sym] = permission.granted
-    end
-    permissions
-  end
-  
-  # Checks for permission on the node and if necessary ascends the
-  # nodetree until permission is found or returns false if it is not found 
-  # at all.
-  def has_permission?(node)
-    node_permission = self.permissions.for_node(node)
-    return node_permission unless node_permission.nil?
-
-    node.ancestors.reverse.each do |p|
-      local_permission = self.get_permissions_for(p)[identifier]
-      unless local_permission.nil?
-        return local_permission
-      end
-    end
-    
-    return false
-  end
-  
   def is_admin?
     !!admin
   end
@@ -176,16 +133,4 @@ class User < ApplicationRecord
     end
     true
   end
-  
-  private
-    
-    def set_permission(granted, node)    
-      permission = self.permissions.for_node(node).first
-      if permission
-        permission.granted = granted
-      else
-        self.permissions.create!( :node       => node, 
-                                  :granted    => granted )
-      end
-    end
 end