Add banner render logic

2 files changed, 19 insertions, 9 deletions

diff --git a/app/models/node.rb b/app/models/node.rb
index ef981a97..8f59de43 100644
--- a/app/models/node.rb
+++ b/app/models/node.rb
@@ -632,6 +632,17 @@ class Node < ApplicationRecord
       .distinct
   end
 
+  def self.current_banners
+    parent = Node.find_by(:unique_name => CccConventions::BANNER_PARENT_NAME)
+    return Node.none unless parent
+
+    parent.children
+          .joins(:head)
+          .where("pages.published_at IS NULL OR pages.published_at <= ?", Time.now)
+          .order("pages.published_at DESC")
+          .includes(:head => { :related_assets => :asset })
+  end
+
   # This one is for admin-only views, where finding a draft is the point.
   # Substring match on whichever of head/draft is present.
   def self.editor_search(term)
diff --git a/app/models/page.rb b/app/models/page.rb
index 91b7e975..679a4aff 100644
--- a/app/models/page.rb
+++ b/app/models/page.rb
@@ -327,17 +327,16 @@ class Page < ApplicationRecord
     end
   end
 
-  def redirect_target
-    return nil if redirect.blank?
-
-    if redirect_node_id.present?
-      return nil unless redirect_node&.head
-      return RedirectTarget.new(redirect_node, nil)
+  def link_target
+    if redirect_node_id.present? && redirect_node&.head
+      RedirectTarget.new(redirect_node, nil)
+    elsif external_url.present?
+      RedirectTarget.new(nil, external_url)
     end
+  end
 
-    return RedirectTarget.new(nil, external_url) if external_url.present?
-
-    nil
+  def redirect_target
+    redirect.present? ? link_target : nil
   end
 
   def redirect_status