summaryrefslogtreecommitdiff
path: root/app
diff options
context:
space:
mode:
Diffstat (limited to 'app')
-rw-r--r--app/controllers/node_actions_controller.rb6
-rw-r--r--app/models/action_participant.rb4
-rw-r--r--app/models/node.rb23
-rw-r--r--app/models/node_action.rb19
4 files changed, 39 insertions, 13 deletions
diff --git a/app/controllers/node_actions_controller.rb b/app/controllers/node_actions_controller.rb
index 6e46719..9b97b45 100644
--- a/app/controllers/node_actions_controller.rb
+++ b/app/controllers/node_actions_controller.rb
@@ -6,7 +6,11 @@ class NodeActionsController < ApplicationController
6 6
7 def index 7 def index
8 @actions = NodeAction.order(:occurred_at => :desc, :id => :desc) 8 @actions = NodeAction.order(:occurred_at => :desc, :id => :desc)
9 @actions = @actions.where(:node_id => params[:node_id]) if params[:node_id].present? 9 if params[:node_id].present?
10 @actions = @actions.joins(:action_participants)
11 .where(:action_participants => { :subject_type => "Node",
12 :subject_id => params[:node_id] })
13 end
10 @actions = @actions.where(:user_id => params[:user_id]) if params[:user_id].present? 14 @actions = @actions.where(:user_id => params[:user_id]) if params[:user_id].present?
11 @actions = @actions.includes(:node, :user) 15 @actions = @actions.includes(:node, :user)
12 .paginate(:page => params[:page], :per_page => 50) 16 .paginate(:page => params[:page], :per_page => 50)
diff --git a/app/models/action_participant.rb b/app/models/action_participant.rb
new file mode 100644
index 0000000..f179a48
--- /dev/null
+++ b/app/models/action_participant.rb
@@ -0,0 +1,4 @@
1class ActionParticipant < ApplicationRecord
2 belongs_to :node_action
3 belongs_to :subject, :polymorphic => true
4end
diff --git a/app/models/node.rb b/app/models/node.rb
index a5a40d3..7a93e79 100644
--- a/app/models/node.rb
+++ b/app/models/node.rb
@@ -4,7 +4,14 @@ class Node < ApplicationRecord
4 4
5 # Associations 5 # Associations
6 has_many :pages, -> { order("revision ASC") }, :dependent => :destroy 6 has_many :pages, -> { order("revision ASC") }, :dependent => :destroy
7
8 # Entries where this node is the primary subject (fast-path column).
9 # For a *complete* history -- including subtree trash/destroy entries
10 # recorded at an ancestor -- use participated_actions instead.
7 has_many :node_actions, :dependent => :nullify 11 has_many :node_actions, :dependent => :nullify
12 has_many :action_participations, :class_name => "ActionParticipant", :as => :subject
13 has_many :participated_actions, :through => :action_participations, :source => :node_action
14
8 belongs_to :head, :class_name => "Page", :foreign_key => :head_id, optional: true 15 belongs_to :head, :class_name => "Page", :foreign_key => :head_id, optional: true
9 belongs_to :draft, :class_name => "Page", :foreign_key => :draft_id, optional: true 16 belongs_to :draft, :class_name => "Page", :foreign_key => :draft_id, optional: true
10 # Autosave pages carry no node_id, so has_many :pages does not cover 17 # Autosave pages carry no node_id, so has_many :pages does not cover
@@ -312,14 +319,14 @@ class Node < ApplicationRecord
312 was_published = head_id.present? 319 was_published = head_id.present?
313 final_published_at = head&.published_at 320 final_published_at = head&.published_at
314 321
315 demoted = 0 322 subtree = [self] + descendants.to_a
316 ([self] + descendants.to_a).each do |node| 323 demoted_nodes = subtree.select do |node|
317 next unless node.head_id 324 next false unless node.head_id
318 former = node.head 325 former = node.head
319 node.head = nil 326 node.head = nil
320 node.draft_id = former.id if node.draft_id.nil? 327 node.draft_id = former.id if node.draft_id.nil?
321 node.save! 328 node.save!
322 demoted += 1 329 true
323 end 330 end
324 331
325 self.reload 332 self.reload
@@ -332,9 +339,10 @@ class Node < ApplicationRecord
332 metadata = { :path => { "from" => path_before, "to" => unique_name } } 339 metadata = { :path => { "from" => path_before, "to" => unique_name } }
333 metadata[:was_published] = true if was_published 340 metadata[:was_published] = true if was_published
334 metadata[:final_published_at] = final_published_at.iso8601 if final_published_at 341 metadata[:final_published_at] = final_published_at.iso8601 if final_published_at
335 metadata[:demoted_heads] = demoted if demoted > 0 342 metadata[:demoted_heads] = demoted_nodes.size if demoted_nodes.any?
336 343
337 NodeAction.record!(:node => self, :user => current_user, :action => "trash", **metadata) 344 NodeAction.record!(:participants => subtree, :user => current_user,
345 :action => "trash", **metadata)
338 self 346 self
339 end 347 end
340 end 348 end
@@ -382,7 +390,8 @@ class Node < ApplicationRecord
382 metadata = { :path => unique_name } 390 metadata = { :path => unique_name }
383 metadata[:destroyed_descendants] = doomed.size - 1 if doomed.size > 1 391 metadata[:destroyed_descendants] = doomed.size - 1 if doomed.size > 1
384 392
385 NodeAction.record!(:node => self, :user => current_user, :action => "destroy", **metadata) 393 NodeAction.record!(:participants => doomed, :user => current_user,
394 :action => "destroy", **metadata)
386 doomed.each(&:destroy!) 395 doomed.each(&:destroy!)
387 end 396 end
388 end 397 end
diff --git a/app/models/node_action.rb b/app/models/node_action.rb
index 63a99ae..8a3dd8b 100644
--- a/app/models/node_action.rb
+++ b/app/models/node_action.rb
@@ -3,6 +3,8 @@ class NodeAction < ApplicationRecord
3 belongs_to :page, optional: true 3 belongs_to :page, optional: true
4 belongs_to :user, optional: true 4 belongs_to :user, optional: true
5 5
6 has_many :action_participants, :dependent => :destroy
7
6 validates :action, presence: true 8 validates :action, presence: true
7 validates :occurred_at, presence: true 9 validates :occurred_at, presence: true
8 10
@@ -81,10 +83,15 @@ class NodeAction < ApplicationRecord
81 # This log records; it does not undo. No IP, session, or user 83 # This log records; it does not undo. No IP, session, or user
82 # agent, ever. Success only. 84 # agent, ever. Success only.
83 85
84 def self.record!(node:, action:, user: nil, page: nil, locale: nil, 86 def self.record!(node: nil, participants: [], action:, user: nil, page: nil,
85 occurred_at: nil, inferred_from: nil, **extra) 87 locale: nil, occurred_at: nil, inferred_from: nil, **extra)
88 participants = participants.presence || [node].compact
89 raise ArgumentError, "NodeAction.record! needs at least one participant" if participants.empty?
90
91 primary_node = node || (participants.first if participants.first.is_a?(Node))
92
86 create!( 93 create!(
87 :node => node, 94 :node => primary_node,
88 :page => page, 95 :page => page,
89 :user => user, 96 :user => user,
90 :action => action, 97 :action => action,
@@ -94,10 +101,12 @@ class NodeAction < ApplicationRecord
94 :metadata => { 101 :metadata => {
95 "username" => user&.login, 102 "username" => user&.login,
96 "human_readable_node_name" => Globalize.with_locale(I18n.default_locale) { 103 "human_readable_node_name" => Globalize.with_locale(I18n.default_locale) {
97 node&.head&.title || node&.draft&.title 104 primary_node&.head&.title || primary_node&.draft&.title
98 }, 105 },
99 }.merge(extra.stringify_keys) 106 }.merge(extra.stringify_keys)
100 ) 107 ).tap do |na|
108 participants.each { |subject| na.action_participants.create!(:subject => subject) }
109 end
101 end 110 end
102 111
103 # Computes the publish-entry diff between an outgoing head and the 112 # Computes the publish-entry diff between an outgoing head and the